allow use of command line arguments again

olafz / percona-clustercheck

Script to make a proxy (ie HAProxy) capable of monitoring Percona XtraDB Cluster nodes properly. The clustercheck script is distributed under the BSD license.

BSD 3-Clause "New" or "Revised" License

173 stars 108 forks source link

allow use of command line arguments again #22

Open jedix opened 6 years ago

jedix commented 6 years ago

Commit 245f1e3 breaks the described usage of the clustercheck script while allowing variables to be set in /etc/sysconfig/clustercheck.

This PR still reads values from this file but overwrites them with values given via command line arguments (if given).

Should also fix #20 and #21.

pcass-epcc commented 5 years ago

Can I ask how the defaults_extra_file parameter is used? It looks like all the parameters are positional, so I can only specify it if I've specified all other parameters, including username and password... but the main reason to use a file would be to avoid putting the username and password on the command line