olafz / percona-clustercheck

Script to make a proxy (ie HAProxy) capable of monitoring Percona XtraDB Cluster nodes properly. The clustercheck script is distributed under the BSD license.
BSD 3-Clause "New" or "Revised" License
173 stars 108 forks source link

Requires passing password insecurely on CLI #8

Closed SpamapS closed 10 years ago

SpamapS commented 10 years ago

Bash doesn't offer us an easy way to redact the password the way mysql's CLI does with --password, and so all users on a system where clustercheck is running will see the password in plain text.

The script should allow users to set user/password to "" as long as DEFAULTS_EXTRA_FILE exists, and then try to use that alone, since it can contain the user/password in a secure location that is only readable by the user running the script.

Will submit a patch.