search

olahol / melody

:notes: Minimalist websocket framework for Go
BSD 2-Clause "Simplified" License
3.75k stars 366 forks source link

Remove default close handler which caused abnormal closes #31

Closed robbiet480 closed 7 years ago

robbiet480 commented 7 years ago

I didn't realize it until today but the default close handler I introduced in #24 was overriding Gorilla's default close handler which caused connections to close with 1006 "CLOSE_ABNORMAL". This change removes the default close handler and only sets a close handler if one is provided to Melody.

robbiet480 commented 7 years ago

@olahol This is an emergency level fix sadly. Can you update the v1 tag with this when you merge it so it gets out ASAP.

olahol commented 7 years ago

Done, thanks for the fix. I have moved v1 to the current head.