search

olahol / react-ab

Simple declarative and universal A/B testing component for React.
432 stars 24 forks source link

Disable .isRequired requirement in Variant propTypes #7

Closed a-omsk closed 8 years ago

a-omsk commented 8 years ago

In some cases we want to test an experiments with nullable children , but it throws warning now.

olahol commented 8 years ago

Good idea, isRequired on Variant children is needlessly restrictive.

olahol commented 8 years ago

isRequired is removed in version 0.4.6. Thanks @a-omsk.