Shouldn't the app_id for Facebook be settable?

olahol / react-social

Simple React components for social buttons (Facebook, Twitter and Pinterest) and social counts.

177 stars 60 forks source link

Shouldn't the app_id for Facebook be settable? #14

Closed queso closed 8 years ago

queso commented 8 years ago

It seems the app_id is hardcoded: https://github.com/olahol/react-social/blob/f4fd7c30fccab6e3e497cb97b8b481b9e52581a4/react-social.js#L249.

From what I've read, this should be set per app, not hardcoded.

olahol commented 8 years ago

You are completely right @queso, I am going to do an overhaul of the library in the near future to fix this and other things, thank you for bringing this to my attention.

queso commented 8 years ago

Happy to help with a PR as I need to get it fixed today for a production deploy this week :)

olahol commented 8 years ago

Thank you, it's up as version 1.0.6, I changed app_id to appId to make it more consistent with the other interfaces, good luck with the production deploy :smile: