search

olahol / react-social

Simple React components for social buttons (Facebook, Twitter and Pinterest) and social counts.
177 stars 60 forks source link

Implement prop isPopup ? #37

Closed thanhtungdp closed 6 years ago

thanhtungdp commented 8 years ago

React-social is a good package. I think you should implement prop isPopup, and if isPopup == true, then open new popup window instead open new tab. Example: http://www.rapidtables.com/web/html/link/html-link-new-window.htm

eminx commented 7 years ago

I think the sharer prop already triggers display=popup but for some reason it gets canceled along the way. I can not address if it's due to facebook or the plugin though...

But you're right, it should be optional.

vladinator1000 commented 7 years ago

This would be awesome! Currently it opens up a new tab by default. Here's how my current workaround:

<FacebookButton
    url={link}
    appId={appId}
    sharer="true"
    windowOptions={['status=0', 'toolbar=0', 'width=480', 'height=350']}
>
</FacebookButton>
olahol commented 7 years ago

I've merged https://github.com/olahol/react-social/pull/46 , which implements this for FacebookButton.