olahol / react-social

Simple React components for social buttons (Facebook, Twitter and Pinterest) and social counts.
177 stars 60 forks source link

Unknown prop `sharer` on <span> tag #43

Closed balmasich closed 7 years ago

balmasich commented 7 years ago

drop warning that sharer is unknown prop

import ReactSocial from 'react-social';
const { FacebookButton, TwitterButton } = ReactSocial;
<FacebookButton
            element={'span'}
            url={url}
            sharer
            className={s.fb}
            appId={sharing.facebook.app_id}
            windowOptions={['status=0', 'toolbar=0', 'width=480', 'height=350']}
          >

warning.js:36 Warning: Unknown prop sharer on tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop

vladinator1000 commented 7 years ago

Having the same issue, it's a bit annoying to see the big red warning in the console.

olahol commented 7 years ago

Thanks, fixed this in 1.6.2.