search

olance / jQuery-switchButton

jQuery UI iPhone-like switch button
111 stars 102 forks source link

Disregard...More options added #2

Closed interlee closed 11 years ago

interlee commented 11 years ago

Please disregard this request. I realized the code should be refined further.

Daniel

olance commented 11 years ago

Okay, I'm closing it and you can create a new request later. Thanks for your involvement though! :)

However, I think this plugin should be completely overhauled... the code doesn't look as nice as it used to when I did the plugin, a long time ago ^^

interlee commented 11 years ago

I love your plug-in!!!! I'd love to see the plug-in getting even more feature rich. As you might have notice, I am a newbie in jQuery plugin, and this is my fist attempt to do any jQuery UI widget thing. Having said this, although I will try another pull request, I am just not confident about the quality of my code at this point.

Thanks a million!

Daniel

On Thu, Aug 29, 2013 at 7:14 AM, Olivier Lance notifications@github.comwrote:

Okay, I'm closing it and you can create a new request later. Thanks for your involvement though! :)

However, I think this plugin should be completely overhauled... the code doesn't look as nice as it used to when I did the plugin, a long time ago ^^

— Reply to this email directly or view it on GitHubhttps://github.com/olance/jQuery-switchButton/pull/2#issuecomment-23484501 .

olance commented 11 years ago

Thank you :)

Sorry for the delay in replying... I'll try to have a look at your pull requests soon :)