search

olange / data-pipes

A set of invisible yet fabulous components to access data
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Lock immutable.js to version 4.0.0-rc.4 #12

Closed yveslange closed 7 years ago

yveslange commented 7 years ago

The data-gql element uses ImmutableJS library.

@leebyron decided to remove the dist/ folder from the library (see: https://github.com/facebook/immutable-js/issues/1387). The dist/ folder normally holds the immutable.min.js bundled file that is used by data-gql

<script src="../../immutable/dist/immutable.min.js"></script>

Since the bundle can't be found and doesn't exists in ImmutableJS v4.0.0-rc4+, I suggest to stick to rc-4 for the moment.

olange commented 7 years ago

We still need to figure out why the Immutable.js project owners changed the way their library is distributed; and how we need to adapt our build process, so to be able to require Immutable.js in our components. In the meantime, as you suggest, lets stick to RC4 and change nothing on our side.