Let eradio-play continue playing while selecting next station

olavfosse / eradio

The simple radio player for GNU Emacs

GNU General Public License v3.0

62 stars 6 forks source link

Let eradio-play continue playing while selecting next station #12

Closed Lenbok closed 3 years ago

Lenbok commented 3 years ago

When eradio is already playing, invoking eradio-play stops playing immediately, so you can't C-g out and have playing be uninterrupted. Let's delay the call to eradio-stop until after we have the next URL.

olavfosse commented 3 years ago

Looks good, I'll merge. Could you first amend the commit to follow the 50/72 rule and be imperative, that is fit into the sentence "if applied this commit will X". Something like the following would be ideal.

Defer eradio-stop till after URL selection

[COMMIT BODY WRAPPED AT 72 CHARACTERS, HERE IS EXTRA TEXT TO
DEMONSTRATE WHERRE THE WRAPPING SHOULD OCCUR. LOREM IPSUM DOLOR SIT
AMET]

Lenbok commented 3 years ago

@fossegrim Done!

olavfosse commented 3 years ago

Lgtm merging