search

olback / es6-css-minify

Easily minify CSS and JavaScript in VS Code
https://marketplace.visualstudio.com/items?itemName=olback.es6-css-minify
MIT License
47 stars 13 forks source link

backgrounfimage url path gets stripped #100

Open schroef opened 4 years ago

schroef commented 4 years ago

Describe the bug Minifying background-image url path gets stripped when using up a couple levels this path "../../../assets/images/" will be this after minifying "assets/images/". It also stripes quotes from the url attribute.

To Reproduce Steps to reproduce the behavior:

  1. Open attached file
  2. Minify it
  3. Open the min version and search for "color.jpg"
  4. See the path has been striped

Expected behavior Dont touch the paths

Screenshots original syntax

Screen Shot 2020-03-04 at 22 28 35

Stripped syntax

Screen Shot 2020-03-04 at 22 28 51

Desktop (please complete the following information):

Test file mbr-additional.css.zip

olback commented 4 years ago

Removal of the quotes around URLs are expected since that is the default behaviour by clean-css. This can be fixed by adding 

"compatibility": {
    "properties": {
        "urlQuotes": true
    }
}

to the setting es6-css-minify.css.

The other issue you're having is that paths are getting rebased which they should not by default. Are you sure that es6-css-minify.css > rebase is set to false? It is set to false by default.

Adding the following to your .vscode/settings.json should fix both issues:

"es6-css-minify.css": {
    "rebase": false,
    "compatibility": {
         "properties": {
              "urlQuotes": true
        }
    }
}