search

olbers / iui

Automatically exported from code.google.com/p/iui
MIT License
0 stars 0 forks source link

Linking to self by fragment results in white page #186

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create a panel in iUI containing a link to itself (href="#ownid")
2. Open the page and click the link.

What is the expected output? What do you see instead?
Nothing should happen. Instead, the panel is hidden and a white screen remains.

What version of the product are you using? On what operating system?
Latest version from Mercurial.

Maybe there should be a check in the onClick handler to do nothing when
source and target is the same.

Original issue reported on code.google.com by hendrik@van-antwerpen.net on 12 Oct 2009 at 1:01

GoogleCodeExporter commented 9 years ago 
I solved a similar issue by doing this:

                                // EVENT focus->currentPage
                                sendEvent("focus", page);

-                               if (fromPage)
+                               if (fromPage && fromPage != page)

Original comment by robert.j...@gmail.com on 22 Oct 2009 at 7:29

GoogleCodeExporter commented 9 years ago 
Hello

Robert your changes won't be enough - if you click on the page the page wont be 
shown
but there will be a new entry in the history. So the backButton will be renamed.

I propose this fix
http://bitbucket.org/maxmelcher/iui-0.40-prototype1/changeset/088bafa9b4a6/

Original comment by melcher....@gmail.com on 28 Oct 2009 at 1:23

GoogleCodeExporter commented 9 years ago 
May be the two fixes should be combined? I often show new pages from code and 
the
clickhandler has nothing to do with that.

Original comment by hendrik@van-antwerpen.net on 4 Dec 2009 at 2:05

GoogleCodeExporter commented 9 years ago

Original comment by msgilli...@gmail.com on 25 Sep 2011 at 5:30