search

oldmoe / litestack

MIT License
1.02k stars 56 forks source link

Add conditional check for sqlite3_production_warning before setting to false in railtie.rb #106

Closed zackgilbert closed 4 months ago

zackgilbert commented 5 months ago

As mentioned in https://github.com/oldmoe/litestack/issues/105, the new Rails main (7.2.0-alpha) removes config.active_record.sqlite3_production_warning and so the litestack railtie attempt to set it to false fails. This is an attempt to fix that.

This is also a better solution (IMHO) than https://github.com/oldmoe/litestack/pull/98, as there are still people utilizing older versions that might need this check. This only fixes it if it's needed.

luizkowalski commented 4 months ago

is there something missing for this PR to get merged? @fractaledmind do you have repo permission to do so?

fractaledmind commented 4 months ago

@luizkowalski @zackgilbert: I can merge it but I can't cut a new release.

Also, the checks are all red, and those need to be fixed before I could merge.

zackgilbert commented 4 months ago

Also, the checks are all red, and those need to be fixed before I could merge.

Apologies, as I'm not familiar enough with the project or the setup, but do we know what the issue is with the checks? Believe this has been an issue since before this PR?

Bundler could not find compatible versions for gem "rack":
  In Gemfile:
    rack (~> 3.0)

    litestack was resolved to 0.4.3, which depends on
      hanami-router (~> 2.0) was resolved to 2.1.0, which depends on
        rack (~> 2.0)
Error: The process '/opt/hostedtoolcache/Ruby/3.0.6/x64/bin/bundle' failed with exit code 6
luizkowalski commented 4 months ago

@zackgilbert yes, PRs have been merged on red for at least 5 months now. I'm trying something on https://github.com/oldmoe/litestack/pull/109, feel free to suggest something

zackgilbert commented 4 months ago

@zackgilbert yes, PRs have been merged on red for at least 5 months now. I'm trying something on #109, feel free to suggest something

Sure, happy to see if I can carve out some time to try some things also.