search

oldmoe / litestack

MIT License
1.02k stars 56 forks source link

Fix test suite and please Standard #109

Closed luizkowalski closed 4 months ago

luizkowalski commented 4 months ago

@fractaledmind I'm taking a stab at fixing the specs. VSCode deleted a couple of extra blanks here and there tho.

Think you can trigger the workflow? I'm getting some erratic behaviors locally, although I managed to run most tests isolated. I'd like to see how it looks like on GitHub

luizkowalski commented 4 months ago

Ok, I think I fixed all specs and found a couple of weird things:

1) test/test_cache_rails.rb class name was actually TestCache and it was clashing with test/test_cache.rb, changed to TestCacheRails. 2) test_helper.rb, as far as I can tell, is not supposed to be a test file, but since the name pattern matches with what's defined on Rakefile (t.test_files = FileList["test/**/test_*.rb"]), it was being added to suite and interfering with the job queue on other files. Renaming it fixed the problem 3) rack doesn't need to be added as a dev dep since hanami-router already depends on rack 4) One test requires activerecord, so I added it as dep.

I got a green suite locally, feel free to try it here, Stephen

luizkowalski commented 4 months ago

Fixed the Standard issues too, I didn't catch them because I have an alias to run rake test and I usually use it instead of just rake

Also, it is best to hide whitespace when reviewing this PR

luizkowalski commented 4 months ago

can we get another shot at this? I'm eager to get this, and a couple of other PRs merged to unblock me on something.