search

oldmoe / litestack

MIT License
1.13k stars 62 forks source link

Litecable must invoke success_callback on #subscribe #41

Closed palkan closed 1 year ago

palkan commented 1 year ago

Without invoking success_callback, subscription confirmation is never sent to the client: https://github.com/rails/rails/blob/main/actioncable/lib/action_cable/channel/streams.rb#L91

Offtopic: why not using Rails' SubscriberMap to maintain subscribers and perform local broadcasts? I think, it could simplify the implantation (and prevent from such incompatibilities, too).

adrienpoly commented 1 year ago

I tested this patch and I can confirm it fixes #23