search

oldmoe / litestack

MIT License
1.09k stars 57 forks source link

Not getting ActionCable connected() when using litecable adapter #59

Closed westonganger closed 10 months ago

westonganger commented 10 months ago

In development when I switch to adapter: litecable in config/cable.yml then it is not calling the connected() function. It does successfully call the initialized() function.

Everything works correctly when I switch back to adapter: async where I get connected() and received()

I am using puma gem for development server on Rails 7.1. Let me know if there is any other information that would be helpful.

adrienpoly commented 10 months ago

I think I had a similar issue but this should be fixed on master by https://github.com/oldmoe/litestack/pull/41

westonganger commented 10 months ago

Yup switch to the master branch fixes this. Maybe we could have a new version released that has a functioning LiteCable implementation.

westonganger commented 10 months ago

Also would be really helpful to add a changelog entry stating this fix.

westonganger commented 10 months ago

@adrienpoly I see that you were trying to add a spec for this regression in another project https://github.com/adrienpoly/rubyvideo/pull/50

Would be awesome if maybe we could get a spec for this inside the litestack repo itself.

adrienpoly commented 10 months ago

For sure yes I wanted to build a dummy app to add to the project but clearly running out of time right now. I f you can propose something that would be great for sure

westonganger commented 10 months ago

Yeah sure, I have the dummy app setup in all my other gems, so I can whip up a PR to get something going.

westonganger commented 10 months ago

Added some PRs to resolve a few of these items

oldmoe commented 10 months ago

I am planning a new release soon that will include all the pending fixes/improvements, just checking what else I can sneak in