oldschoolgg / oldschoolbot

Old School Bot - A fanmade discord bot based on Old School RuneScape (OSRS)
https://www.oldschool.gg/
MIT License
139 stars 122 forks source link

Coal bag at blast furnace gives incorrect boost #5086

Open DarkBugz opened 1 year ago

DarkBugz commented 1 year ago

Based on the strategy in the osrs wiki, all coal bars require exactly half the trips when using coal bag so coal bag should give a 50% boost. The following timeToUse rates should be applied to blastables to be consistent with in game rates assuming a 50% boost for coal: Bronze - .96 Iron - .425 Silver - .425 Steel - 1.22 Gold - .425 Mithril - 1.85 Adamantite - 2.47 Runite - 3.1

DarkBugz commented 1 year ago

Graceful is also giving the wrong nerf. Should be timeToSmithSingleBar /= .925

TastyPumPum commented 1 year ago

The message says coal bag is a 60% boost but the code is only giving 37.5% boost. Should be timeToSmithSingleBar *= .4

https://github.com/oldschoolgg/oldschoolbot/pull/1793#discussion_r625499624

DarkBugz commented 1 year ago

That's not how any other boost in bso works. If that's the intent them the message should say 37.5% boost

TastyPumPum commented 1 year ago

That's not how any other boost in bso works. If that's the intent them the message should say 37.5% boost

Then the message should be changed to be consistent, but just saying to change the whole code and rates without testing is not the correct approach

DarkBugz commented 1 year ago

I assumed the boost it stated was the intent not the boost in the code. In osrs a coal bag would speed up all the bars by 2x https://oldschool.runescape.wiki/w/Blast_Furnace/Strategies which is a 50% boost, *=.5 or /=2