oldschoolgg / oldschoolbot

Old School Bot - A fanmade discord bot based on Old School RuneScape (OSRS)
https://www.oldschool.gg/
MIT License
139 stars 122 forks source link

DT2 item incorrect data #5950

Open nwjgit opened 2 months ago

nwjgit commented 2 months ago

🐛 Bug Report

https://github.com/oldschoolgg/oldschoolbot/commit/6b02a88d7ccdca31a82ec71526c363b0a248c450 introduced item switches which switched the dt2 rings from beta id to the proper id but the price and associated wiki page seem to use the beta id information.

other issues:

Follow up to: https://github.com/oldschoolgg/oldschoolbot/issues/5284

gc commented 2 months ago

The IDs have not changed. The beta versions now just match the data of the real ones. Removing the beta IDs would (same as before) require all the existing items to be migrated to the new one, which is a pain to do.

nwjgit commented 2 months ago

The IDs have not changed. The beta versions now just match the data of the real ones. Removing the beta IDs would (same as before) require all the existing items to be migrated to the new one, which is a pain to do.

It's a pain to do but its probably the only real solution. The one currently implemented isn't doing the trick as seen in the original post. i'm not 100% sure how you handled the blood vial fix but I would imagine its the exact same process to remove and migrate the ids and prevent future creation of the wrong id item.