search

oldschoolgg / oldschoolbot

Old School Bot - A fanmade discord bot based on Old School RuneScape (OSRS)
https://www.oldschool.gg/
MIT License
139 stars 123 forks source link

Colosseum refunding more charges than it should #5974

Open ghosts-are-spooky opened 2 months ago

ghosts-are-spooky commented 2 months ago

🐛 Bug Report

Colosseum refunds charges for items based on progress - scythe, amulet of blood fury, more?

When trip returns it is not accounting for saved charges from penny, so you end up with a net gain in charges for failed attempts, see below:

@Tom, you died on wave 1 to Serpent Shaman, and received no loot. No new KCs. Refunded 300 charges for Scythe of vitur. Total charges: 20264. Refunded 900 charges for Amulet of blood fury. Total charges: 30045.

@Tom, you died on wave 1 to Jaguar Warrior, and received no loot. No new KCs. Refunded 300 charges for Scythe of vitur. Total charges: 20274. Refunded 900 charges for Amulet of blood fury. Total charges: 30098.

Not hugely abusable as it's only on wipes which get reduced over time.

nwjgit commented 2 days ago

5984 didn't correct the issue, i'll troubleshoot and find a fix when I add make multi-trip colo for OSB.

Note to future self: The issue appears to be The original charge amount is being saved and not the new charge value after Ghommal's lucky penny saved charges is factored in. i.e. use 50 venator charges, penny saves 2 charges so 48 removed, but then 50 is refunded instead of 48.

Discord_afUVPkyliM