oldschoolgg / oldschoolbot

Old School Bot - A fanmade discord bot based on Old School RuneScape (OSRS)
https://www.oldschool.gg/
MIT License
143 stars 132 forks source link

Add corruptedYoungllef creatable #6150

Closed Felris closed 1 month ago

Felris commented 1 month ago

Description:

Adds Corrupted Youngllef as a creatable

Changes:

Added corrupted youngllef as creatable/revertable. Create checks for 1 corrupted gauntlet KC.

Other checks:

nwjgit commented 1 month ago

You should put these under their respective sections: metamorphPets and revertMetamorphPets

also minor edit: you could end the fail message with a period and remove the else statement and just leave the if and return null at the very end, similar to other customreqs.

like:


            const [kcName, kcAmount] = await user.getKCByName('Corrupted gauntlet');
            if (kcAmount < 1) {
                return `You need to have at least 1 ${kcName} KC.`;
            }
            return null;
        }
Felris commented 1 month ago

You should put these under their respective sections: metamorphPets and revertMetamorphPets

also minor edit: you could end the fail message with a period and remove the else statement and just leave the if and return null at the very end, similar to other customreqs.

like:

          const [kcName, kcAmount] = await user.getKCByName('Corrupted gauntlet');
          if (kcAmount < 1) {
              return `You need to have at least 1 ${kcName} KC.`;
          }
          return null;
      }

Yeah I had done that originally, but I personally prefer explicit else's so I did it my own way. But it's not my code, so you're right, and I updated it to match.