Prevent repeating kill trips when slayer task is finished

DayV-git commented 5 days ago

Description:

Add underlying onTask boolean to check if repeated monster killing trip is off task, but original trip was on task. If so, don't do the trip. Can then either get new task, or just use /k again to kill the same monster if you really want to. There were other options, like a confirmation message, but probably unnecessary. https://github.com/oldschoolgg/oldschoolbot/pull/6185

Closes #5972.

Changes:

Add onTask boolean to MonsterActivityTaskOptions and minionKCommand, the latter only accessed via repeat trip.
Return fail message when current slayer task has finished but trying to repeat kill the same monster.

Other checks:

[x] I have tested all my changes thoroughly.

gc commented 5 days ago

Did people agree/like this idea?

DayV-git commented 4 days ago

Did people agree/like this idea?

Poll is pretty clear. The bot used to have this functionality but it was removed (unintentionally) a while ago, so to me it was a no-brainer.

oldschoolgg / oldschoolbot