Fixing pickpocket Pollnivnian vs Bearded conflict

oldschoolgg / oldschooljs

A utility library for all things oldschool runescape related.

https://docs.oldschool.gg/

MIT License

46 stars 50 forks source link

Fixing pickpocket Pollnivnian vs Bearded conflict #264

Closed LuxrayElite closed 2 years ago

LuxrayElite commented 2 years ago

Description:

Thieving would opt to pickpocket lvl 45 bearded bandits instead of 55 pollnivnian bandits due to conflicting aliases and matching mosters.id

Changes:

Removed 'Pollnivnian bandit' as alias causing conflicts in thieving code. Changed pollnivian bandit id to 735 (non bearded)
[x] I have tested all my changes thoroughly.

LuxrayElite commented 2 years ago

Whilst the XP rates have changed the completion message does, I am assuming this is because both Pollnivnian bandits share a monster.id value and bearded comes before pollnivnian

Screenshot detailing how the change will effect thieving: