search

ole / OLEContainerScrollView

A UIScrollView subclass that intelligently handles multiple child scroll views and does not interfere with UIKitʼs cell reuse functionality.
http://oleb.net/blog/2014/05/scrollviews-inside-scrollviews/
MIT License
587 stars 67 forks source link

Private api usage #15

Closed LukeDefeo closed 8 years ago

LukeDefeo commented 8 years ago

Hey cool project, but is this suitable in a commercial application? i noticed private api usage in https://github.com/ole/OLEContainerScrollView/commit/2db7ddb82e5081f55ad5336f7bd47b4afdac8aa6

If i remove this code what defects/issues can i expect?

Maybe we could create a app store safe branch?

ole commented 8 years ago

If you don't call swizzleUITableView() (and remove the related code), cell inserts or removals in table views will not animate correctly. That's the issue the override of the private API solves.

A branch that doesn't use private API is a good idea, but I don't think I'll be doing it, sorry. I just don't want the maintenance burden. Please see this project more like a proof of concept. You're welcome to use this in your own app, but it's not gonna be a perfect solution that works for everyone without changes.