search

ole / OLEContainerScrollView

A UIScrollView subclass that intelligently handles multiple child scroll views and does not interfere with UIKitʼs cell reuse functionality.
http://oleb.net/blog/2014/05/scrollviews-inside-scrollviews/
MIT License
587 stars 67 forks source link

Support WKWebView and other views that are not subclasses of UIScrollView #21

Closed tomaskraina closed 6 years ago

tomaskraina commented 6 years ago

Hey @ole,

First, thanks for the good work on this project! I have extended it a bit to fit my needs by supporting other more complex view that are not direct subclasses like WKWebView. Moreover, the OLEContainerScrollView has been extended to ignore hidden subviews. It works in similar fashion to what UIStackView does.

Please check the added example and merge it in if you find it useful.

Cheers, Tom

ole commented 6 years ago

@tomaskraina First of all, thank you for the contribution! It looks like a nice and very useful addition (although I haven't looked at the sample app) and I'm going to merge it in.

I apologize for letting this PR sit here so long unattended. The reason is that I don't know what to do with this repo.

I think I'm going to archive it in the near future. The main reason I published the code in 2014 was so that I could write about it. I don't use this component myself, I don't want to maintain it, and I'm also not interested (I think) in growing the feature list more and more. I'd rather this repo stand on its own as the documentation for my 2014 article.

People are still welcome to use the code and extend it in their own code, of course (as you already do).