oleander / git-fame-rb

A command-line tool that helps you summarize and pretty-print collaborators based on contributions
MIT License
957 stars 74 forks source link

git_fame/author.rb:68:in `inc': wrong number of arguments (given 0, expected 2) (ArgumentError) #78

Open linkdata opened 7 years ago

linkdata commented 7 years ago

The source repo is private, unfortunately. But maybe the stack dump will help.

$ git fame --branch=develop --whitespace --by-type
Git Fame:      100% |oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo| Time:   0:01:06

Statistics based on develop
Active files: 1,880
Active lines: 393,585
Total commits: 9,127

Note: Files matching MIME type image, binary has been ignored

/var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/author.rb:68:in `inc': wrong number of arguments (given 0, expected 2) (ArgumentError)
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/object_table.rb:10:in `block (2 levels) in render'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/object_table.rb:10:in `each'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/object_table.rb:10:in `inject'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/object_table.rb:10:in `block in render'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/object_table.rb:9:in `each'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/object_table.rb:9:in `inject'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/object_table.rb:9:in `render'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/helpers/auto_table.rb:22:in `render'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/formatter.rb:73:in `_format_output'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/formatter.rb:56:in `format_output'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/view.rb:205:in `render_output'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/console.rb:18:in `render_output'
        from /var/lib/gems/2.3.0/gems/hirb-0.7.3/lib/hirb/console.rb:30:in `table'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:108:in `pretty_puts'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/bin/git-fame:53:in `<top (required)>'
        from /usr/local/bin/git-fame:23:in `load'
        from /usr/local/bin/git-fame:23:in `<main>'
linkdata commented 7 years ago

Also happens with --format=csv.

$ git fame --branch=develop  --by-type --format=csv
Git Fame:      100% |oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo| Time:   0:00:56
/var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/author.rb:68:in `inc': wrong number of arguments (given 0, expected 2) (ArgumentError)
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:126:in `block (3 levels) in to_csv'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:125:in `map'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:125:in `block (2 levels) in to_csv'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:124:in `each'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:124:in `block in to_csv'
        from /usr/lib/ruby/2.3.0/csv.rb:1166:in `generate'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:122:in `to_csv'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/lib/git_fame/base.rb:115:in `csv_puts'
        from /var/lib/gems/2.3.0/gems/git_fame-2.5.2/bin/git-fame:53:in `<top (required)>'
        from /usr/local/bin/git-fame:23:in `load'
        from /usr/local/bin/git-fame:23:in `<main>'
duffyjp commented 7 years ago

It's not --format=csv but --by-type

MacOS

🍕  git-fame-rb 15:17$ rspec ./spec/bin_spec.rb[1:10] # bin/git-fame should support --by-type
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
Run options: include {:ids=>{"./spec/bin_spec.rb"=>["1:10"]}}
-----------
Current environment:
    git version 2.11.0 (Apple Git-81)
    grep (BSD grep) 2.5.1-FreeBSD
Spec notes:
    Messages to STDOUT has been suppressed. See spec/spec_helper.rb
    Requires git 2.x for specs to pass
    Time zone during testing is set to GMT-2
-----------

bin/git-fame
  should support --by-type (FAILED - 1)

Failures:

  1) bin/git-fame should support --by-type
     Failure/Error: run(option).should be_a_succees
       expected command to be a success, but failed
     # ./spec/bin_spec.rb:41:in `block (3 levels) in <top (required)>'

Finished in 0.4524 seconds (files took 0.31947 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/bin_spec.rb[1:10] # bin/git-fame should support --by-type

Ubuntu 14.04

$ rspec ./spec/bin_spec.rb[1:10]
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
Run options: include {:ids=>{"./spec/bin_spec.rb"=>["1:10"]}}
-----------
Current environment:
    git version 2.13.0
    grep (GNU grep) 2.16
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Mike Haertel and others, see <http://git.sv.gnu.org/cgit/grep.git/tree/AUTHORS>.
Spec notes:
    Messages to STDOUT has been suppressed. See spec/spec_helper.rb
    Requires git 2.x for specs to pass
    Time zone during testing is set to GMT-2
-----------

bin/git-fame
  should support --by-type (FAILED - 1)

Failures:

  1) bin/git-fame should support --by-type
     Failure/Error: run(option).should be_a_succees
       expected command to be a success, but failed
     # ./spec/bin_spec.rb:41:in `block (3 levels) in <top (required)>'

Finished in 0.41151 seconds (files took 0.19143 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/bin_spec.rb[1:10] # bin/git-fame should support --by-type