oleavr / frida-agent-example

Example Frida agent written in TypeScript
https://www.frida.re/
725 stars 182 forks source link

Interceptor::flush is missing in the node.js package #7

Closed Sh3idan closed 4 years ago

Sh3idan commented 4 years ago

In the frida-gum node-js package version 16.0.0, the function Interceptor::flush is missing. According to the documentation (https://frida.re/docs/javascript-api/#interceptor), we expect to have the following defintion in the index.d.ts file:

    /**
     * Ensure any pending changes have been committed to memory.
     */
    function flush(): void;

I'm sorry if it is not the right place to report that.

oleavr commented 4 years ago

Ahh thanks, nice catch! Would you be interested in submitting a PR to DefinitelyTyped? If it's too much hassle let me know and I can do it, but think it would be great if the change was attributed to you.

Sh3idan commented 4 years ago

I will look into doing this. Thanks for this link !