search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 358 forks source link

Using echo instead of gin #14

Closed javiercbk closed 8 years ago

javiercbk commented 8 years ago

I don't think you should accept this pull request but it might be interesting to see some limitations about migrating to echo.

First of all, there is no easy way to make a not found handler work because echo's notFoundHandler is a hidden property of the Echo struct (this affects the react server side rendering). You can verify it by checking https://github.com/labstack/echo/blob/master/echo.go at line 30. I have not seen any other quick way but there must be some kind of hack to be performed.

All the changes I've made were really quick so this is a working draft and I was hoping to get some feedback.

javiercbk commented 8 years ago

Got it working, pulling complete version