search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 358 forks source link

Migrated from Gin to Echo #15

Closed javiercbk closed 8 years ago

javiercbk commented 8 years ago

Got it working with echo, some feedback would be nice. I was forced to make a hack with echo in order to get the index page "/" to be handled by React template, but I think there must be a cleaner way to achieve that.

olebedev commented 8 years ago

Hey @javiercbk,

Please test the app with make build to ensure that the project still can be compiled before send a PR. Also I leave some comments above.

javiercbk commented 8 years ago

Thanks, for all the feedback. I will be fixing all the things that you've pointed out. Sorry about the early PR, I don't have much experience contributing in github. I'm closing this since there is much to work and I will get back to you when it's done

olebedev commented 8 years ago

@javiercbk it is not necessary each time close a PR, you can fix the code and push into the same branch.

jsloyer commented 8 years ago

@javiercbk, @olebedev curious why you moved off of to Gin to Echo...

javiercbk commented 8 years ago

@jsloyer I wanted to understand the whole project, and it seemed useful to everyone if I "checked" one of the TODO tasks listed on the README.md. To satisfy your curiosity, I personally use negroni for my go web projects.

olebedev commented 8 years ago

Hi @jsloyer, I am watching for gin about 1,5 years. And I see that the project developed not for commercial usage but just as student's task. Developing is move forward intermittent(gin has many issues related on this). Yeah, it was the one incredibly fast framework. But now the situation is changed. Also, the API is not kept as simple and clean instead of permanent pretty ambiguous changes. And the last is that gin has own refactored httprouter implementation. Which is not allow to define usual URI routine scheme(gin has a lot of issues about it).