search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 358 forks source link

Production builds are including some dev resources #31

Closed simonklee closed 8 years ago

simonklee commented 8 years ago

NODE_ENV=production make build creates a js bundle which is 373K. Removing the references to redux-devtools in client/ and running the same command again reduces the size by ~70K.

EdVanDance commented 8 years ago

Here's a fix.

olebedev commented 8 years ago

Yep, thanks, @EdVanDance. It's just need to import by the condition. Define plugin already there. I'll fix it soon.

simonklee commented 8 years ago

Yes, I've used the same docs as a reference for my personal branch of this.

On Mon, Feb 1, 2016 at 10:18 AM, Oleg Lebedev notifications@github.com wrote:

Yep, thanks, @EdVanDance https://github.com/EdVanDance. It's just need to import by the condition. Define plugin already there. I'll fix it soon.

— Reply to this email directly or view it on GitHub https://github.com/olebedev/go-starter-kit/issues/31#issuecomment-177870848 .

olebedev commented 8 years ago

@simonz05, would you send it as a PR?

olebedev commented 8 years ago

Need to fix in #28.