search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 358 forks source link

Fix for: Update npm dependencies #34

Closed franklinkim closed 8 years ago

franklinkim commented 8 years ago

This should do it. There was sth with the react-router. I also re-added the devtools since i forgot to add them the last time.

I had to comment out this block:

  if (process.env.NODE_ENV !== 'production'){
    store.subscribe(() => {
      console.log('%c[STORE]', 'color: green', store.getState());
    });
  }

since it keeps on logging due to the devtools.

olebedev commented 8 years ago

@franklinkim thanks! I had just reverted your previous PR. Could you resolve the conflicts manually, please?

olebedev commented 8 years ago

This block was added before devtool and i forgot to remove it. Or cause it should be deleted.

franklinkim commented 8 years ago

ok, merge your current master and removed the block. might wanna recheck before merging :P

olebedev commented 8 years ago

Thanks! It was a good idea to check it before merge ) Not critical, I had to fixed react-router warning produced at the server in the render moment. Take a look: https://github.com/olebedev/go-starter-kit/commit/b2ddbac124ff56e77f6679daec3b4e787d423338.

franklinkim commented 8 years ago

ah nice, missed that one while merging and didn't see the error. thx!