search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 358 forks source link

Doesn't work with React 15.0 #47

Closed valerius257 closed 8 years ago

valerius257 commented 8 years ago

After updating React to 15.0 everything compiles successfully but project doesn't start.

capture

olebedev commented 8 years ago

Thank for the report. Once I'm fix it I'll ping here.

ghost commented 8 years ago

This is a React bug caught by Duktape! The problem is an invalid escape char in one of the regexes introduced in this commit: https://github.com/facebook/react/commit/a2b471e09850f1546fd2526149fc04992cb85b80

here is the patch: https://github.com/facebook/react/pull/6772

P.S. It would be useful to see the stack trace in these situations server/react.go#L180

valerius257 commented 8 years ago

I can confirm that using React from 32c750de5c47436168b742275ebe21852dcca172 solved the issue

abh commented 8 years ago

Close this?

olebedev commented 8 years ago

@abh yup!