olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 358 forks source link

Ignore go build failure in makefile #48

Open dfilipovic39 opened 8 years ago

dfilipovic39 commented 8 years ago

Hi, there seems to be a problem when you modify go code, and makefile tries to rebuild server. If there is any compile time error the makefile recipe crashes.

Possible soultion would be prefixing build command with - : -@go build -ldflags '$(LDFLAGS)' -o $@ $(IMPORT_PATH)/server

Failed build will be ignored this way and old binary would be used

olebedev commented 8 years ago

Hi @tarqe39,

thank you for the suggestion! BTW, pull requests are welcome.