search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 358 forks source link

Moved config from string to file #50

Closed danbarbarito closed 7 years ago

danbarbarito commented 8 years ago

Gofmt automatically converts tabs to spaces, which is a problem since YAML only likes spaces. Because of this, gofmt-ing config.go causes builds to fail. I moved the config out to a separate YAML file, which seems cleaner anyway.

rtuin commented 8 years ago

There is more in this PR than what you're describing: I suggest creating your pull-request from a branch that only contains these changes and not from your master branch.

olebedev commented 7 years ago

Hi @danielbarbarito,

thanks for your suggestion. Unfortunately, I cannot merge this b/c the project uses go-bindata and keeps all the files inside.