search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 359 forks source link

update echo web framework #54

Closed 0xp3p3 closed 7 years ago

0xp3p3 commented 7 years ago

Thanks, Olebedev. I installed go-starter-kit on my mac book after check some issues that posted before. I have one request, Echo is updated to v2.0, there are some issues to update echo in go-starter-kit. Please help me, can you update the go-starter-kit with echo 2.0?

Thanks,

olebedev commented 7 years ago

Sure, it's a good practice to keep all project's dependencies up-to-date. Due to time lack, I cannot do it quickly. Any pull request will be a really appreciated.

0xp3p3 commented 7 years ago

Hello, Sir I am facing below issues.

screen shot 2016-08-22 at 9 56 05 am

// Initialize the application app := &App{ Conf: conf, Engine: engine, API: &API{}, React: NewReact( conf.UString("duktape.path"), conf.UBool("debug"), engine, ), } ... ...

screen shot 2016-08-22 at 9 57 48 am

// Map app struct to access from request handlers // and middlewares app.Engine.Use(func(c echo.Context) error { c.Set("app", app) return nil })

:) I am a golang beginner. How can I fix it? I have fixed other some issues. Looking forward to hearing from you soon. Thanks, Best Regards,

rtuin commented 7 years ago

I've found a fork that upgrades to echo v2 here: https://github.com/phuongvu/go-starter-kit/commit/43f456fe8b8f387f1f27c06100358c4f40b2ab7c I'm not sure what the quality is, but perhaps this is a good starting point!

olebedev commented 7 years ago

@rtuin,

https://github.com/phuongvu/go-starter-kit/commit/43f456fe8b8f387f1f27c06100358c4f40b2ab7c looks good to me.

rtuin commented 7 years ago

I created #55 to address the upgrade to echo v2

flamedmg commented 7 years ago

Echo V3 is out. Breaking changes again

euphario commented 7 years ago

Hi, I am fairly new to Go, but base on the work from @phuongvu I tried to update Echo to v3. It seems to work for me (so far).

If anybody wants to check it out. I apologies in advance, my knowledge of github and git in general is pretty limited.

gitlab.com/theloin/go-starter-kit

olebedev commented 7 years ago

65