Modify code to accomodate Echo V2

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit

Other

2.82k stars 359 forks source link

Modify code to accomodate Echo V2 #55

Closed rtuin closed 7 years ago

rtuin commented 7 years ago

Should close: https://github.com/olebedev/go-starter-kit/issues/54

All credits go to @phuongvu. This commit was cherry-picked from that fork.

@olebedev I'm not sure how to update the srlt.yaml file. Can you explain how I should do that?

olebedev commented 7 years ago

hi @rtuin,

it's as simple as a cake. Just need to drop these lines and run srlt s. Make sure that ./vendor/gopkg.in/labstack/echo.v2 installed and have .git folder.

rtuin commented 7 years ago

Thanks @olebedev. I've added the updated srlt.yaml file now!

olebedev commented 7 years ago

@rtuin

looks good to me. Only two things have to ask you to change:

get rid of github.com/dgrijalva/jwt-go, since it's have not been used;
drop e.Use(middleware.Gzip()) line, since, actually, the best practice is to use nginx for this kind of issues.

Thanks.

rtuin commented 7 years ago

Thanks for taking a look. I'll probably have time to look at this again on Monday!

phuongvu commented 7 years ago

Hey @rtuin, I'm glad that you find my fork useful!

joelnb commented 7 years ago

If anyone is still interested in this I made a version which works with the new vendoring scheme: https://github.com/joelnb/go-starter-kit/tree/echo.v2

I also had a look at supporting echo v3 which is out now but there are quite a few changes and I haven't yet got it working.

EDIT: Forgot to mention, in order to get it working I had to glide update in order to make the dependencies resolvable. This means that all dependencies have been updated to the latest version. Everything does seem to work fine though.

olebedev commented 7 years ago

@joelnb, thanks for the attempt. It would be definitely good to have the dependecies updated. Looking forward for a new PR!

joelnb commented 7 years ago

@olebedev take a look at https://github.com/olebedev/go-starter-kit/pull/65 for a version which uses the latest version of echo & updates all the other dependencies.