search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 359 forks source link

Stopped rendering server side #77

Open preppypiet opened 7 years ago

preppypiet commented 7 years ago

Hi, great library, thanks! I think a recent (as in last day or so) change in one of the node libraries used by the project is causing server-side rendering to fail. I haven't had a chance to take a look at exactly what's going on, and I have no idea yet what library is causing this, but you can reproduce it by cloning this repo, make install and make serve. In your browser, disable javascript for the page and you'll see an empty page returned from server when refreshing the page. This is happening on both linux and macos for me. I know it's something client-side, because I had an old bundle.js produced a day or two ago in another folder, and by dropping it in, it worked again. Something in the webpack output has changed I think. I'll look into this some more to see where exactly the issue is occurring, but thought I'd let you know in case you might have any ideas? I can see that if I remove the in toString.js, the app renders server side again. The issue is probably something related to the redux store.

olebedev commented 7 years ago

Hi, yup, unfortunately client-side deps have changed dramatically so the project could not even start correctly. I will fix this asap, but have no chance to predict when it can happen. B/c of lack of time. I would be really appreciate if some good man will help with this issue.

preppypiet commented 7 years ago

I'd love to help! I should have some time this weekend to take a proper look and see what's going on. Can't promise anything, but I'll take a look as soon as I can.

senthilsivanath commented 6 years ago

Resolving all JS warnings, got the server side compilation again.