search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 359 forks source link

Webpack 2 #79

Closed ufukomer closed 7 years ago

ufukomer commented 7 years ago

I am already updating npm packages for myself. I would send 'all npm packages updated' version of this if you like it.

olebedev commented 7 years ago

Hi,

thanks for sharing this. Is HMR works with webpack 2 as expected?

/cc @preppypiet

ufukomer commented 7 years ago

Hey @olebedev,

Css hot module replacement was not work as expected. So I have added a tricky fix for it. I don't know why its normal version does not work. Now it works. But it's okay to close pr if you don't like this solution for css hmr -> ac3e95ce581678ef59763dc237366eaf131447bd

olebedev commented 7 years ago

@ufukomer

Oh. My. God. Looks dangerous. I would prefer to avoid things like that. But anyway thanks for trying to help I really appreciate this.