search

olebedev / go-starter-kit

[abandoned] Golang isomorphic react/hot reloadable/redux/css-modules/SSR starter kit
Other
2.82k stars 359 forks source link

Server remains in background on exit #84

Closed nazwa closed 7 years ago

nazwa commented 7 years ago

Stopping make serve with ctrl + c leaves the go server running in background.

And it continues serving (and outputting) requests:

Unfortunately this is way beyond my make skills to fully dig into myself. All the other processes seem to quit just fine. Not sure what's different about the server.

This might be completely unrelated, but during the initial startup it does say that it couldn't find the right process. Leftover pid from the previous run? 

Ubuntu 16.04.2 LTS running in WSL
olebedev commented 7 years ago

Seems something went wrong. Could you kill go-starter-kit server's process and run make serve again? What is the result?

nazwa commented 7 years ago

If I do manually kill the server process - make serve starts as if nothing happened.

If I don't manually kill the server process, make serve also starts as if nothing happened, and kills the server using pid saved in the file

It's not the end of the world, but it is a bit inconvenient to have the orphaned process running 😄

nazwa commented 7 years ago

Seems to have fixed itself 😕 No clue what was happening there.