olebedev / when

A natural language date/time parser with pluggable rules
Apache License 2.0
1.33k stars 81 forks source link

Ability to use a different timezone? #23

Open ashishb opened 4 years ago

ashishb commented 4 years ago

I couldn't see to find any timezone parsing code. So, for example, if I am saying "10 PM EST" while the machine's local time is in PST then I expect 7 PM as the outcome in local time or 10 PM with the timezone information extracted.

olebedev commented 4 years ago

It's supposed that you already know or parse a timezone and give a time.Time instance with already set up timezone in it.

ashishb commented 4 years ago

I want to extract it from the free-form text.

ShadiestGoat commented 1 year ago

I think this issue should be re-opened. It should be able to parse "7pm PST" and "7pm UTC" differently.

Thank you!

olebedev commented 1 year ago

Yeah, it seems like a useful feature to have in the library. I think it can be relatively easy implemented as a rule, that parses only timezones if any and adjust the result accordingly.

I open the issue to keep it visible. It would be really cool if someone can spend a couple of hours implementing the rule :) I will be happy to review and merge when its ready to.