search

olebole / python-cpl

Python bindings for CPL recipes
http://pypi.python.org/pypi/python-cpl
GNU General Public License v2.0
10 stars 5 forks source link

Add signal handler to ignore SIGWINCH #9

Closed saimn closed 7 years ago

saimn commented 7 years ago

Ref #8

Not sure if it is the best place to put it ?

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.005%) to 76.475% when pulling 3b6196de38cc566aa7ee24123c1dc1002f61d677 on saimn:fix-sigwinch into bdbcd6afaaffc4c7882f05c2a93805b1f9105031 on olebole:master.

saimn commented 7 years ago

Travis fails because Python 2.6 support has been removed in Astropy 1.2

olebole commented 7 years ago

After some thinking, I guess that that will not work well but has an unexpected side effect: it reverts the SIGWINCH change that was made in Python 2.7.12 after running the first recipe, so that the command line will not discover it anymore. When I had this idea, I thought to implement it in the child process only, but there it does not make sense at all (that was my mistake). Probably the only solution would be to loop over read() until completeness.

saimn commented 7 years ago

Ok, it makes sense.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.005%) to 76.475% when pulling c435836abe41ae8eb3629d8e9bff703ff48ceb5a on saimn:fix-sigwinch into bdbcd6afaaffc4c7882f05c2a93805b1f9105031 on olebole:master.