oleeskild / digitalgarden

275 stars 158 forks source link

Adds user selected language in <html lang=""> #208

Closed stalegjelsten closed 10 months ago

stalegjelsten commented 11 months ago

Must be seen in connection with https://github.com/oleeskild/obsidian-digital-garden/pull/473 and https://github.com/oleeskild/obsidian-digital-garden/issues/472

This commit uses the SITE_MAIN_LANGUAGE set in the .env for all lang attributes in html elements. If no SITE_MAIN_LANGUAGE is set, it defaults to <html lang="en">.

This is part of my first pull request (and I have zero Obsidian plugin development experience), so please be very critical of my work.

oleeskild commented 10 months ago

This looks good! I've also looked over the corresponding PR in the plugin repo, which also looks good. I'll release it right away. Thanks for the contribution!