search

oleeskild / digitalgarden

261 stars 147 forks source link

Update and rename build.yml to deploy.yml #232

Open b- opened 8 months ago

b- commented 8 months ago

This adds a GitHub Pages deployment stage to the build workflow, which I thus renamed to “deploy.yml”

I’m not sure if you’re interested in adding this or not, but I figured it would be worth proposing the change anyway.

Note: I have not actually tested this, because the repo I use for my own live DG site is private and therefore won’t let me use Pages for free. So if you decide to incorporate this change, please keep that in mind — there might be a missing parameter or a typo or something. Therefore I have marked this as a draft.

I’m not sure if I’ll use GH Pages myself, but if I do test this myself I’ll update the PR. Otherwise it’s there in case you’re interested in testing and merging it.

Thanks for the awesome repository and great documentation! If I get confident enough in my own site and add a little more content I might make a PR to add it to the list, but I’m shy… 🙈

b- commented 7 months ago

I tested this against a basic site, deploying a couple of times, but then I decided I wanted my site private again.

b- commented 7 months ago

Seems simply adding a deploy step wasn't a great idea, because that workflow runs for PRs. So I replaced build.yml, but only running on PRs (and removed the on.pull_request thing from deploy.yml