oleeskild / obsidian-digital-garden

MIT License
1.23k stars 117 forks source link

Handling of Embedded Excalidraw Images #525

Open Luke-zhang-04 opened 7 months ago

Luke-zhang-04 commented 7 months ago

Looks like Excalidraw just introduced a breaking change in a minor version (https://github.com/excalidraw/excalidraw/pull/7251 at https://github.com/excalidraw/excalidraw/releases/tag/v0.17.0), and right now we're loading Excalidraw as excalidraw@0, so in short, not nice, things are broken.

Before we fix this, I think we should also change how we handle Excalidraw drawings. Instead of transforming the drawings at the plugin level, I think it's better if we handle them during the build phase. I think that's more flexible and less fragile. We can do things like displaying drawings as SVGs when they are embedded. Thoughts?

Luke-zhang-04 commented 7 months ago

Related to #507

creativefibro commented 6 months ago

I have just shared a page with an Excalidraw image embedded and realised it was missing. Is there any update on this and how it can be seen as the note makes little sense without the drawing below it. Thanks

ethanmiller1 commented 1 month ago

Has this been resolved? My images are not rendering in the garden.

Digital Garden: image

Obsidian: image