olefirenko / vue-google-autocomplete

A Vue.js autosuggest component for the Google Places API.
https://olefirenko.github.io/vue-google-autocomplete/
MIT License
507 stars 258 forks source link

IE11 Issue #127

Open mrdigitalau opened 5 years ago

mrdigitalau commented 5 years ago

Hey mate, thanks very much for this plugin.

Works great for me on most browsers but seems to cause an error on IE11 which stops vue from working completely.

I get an error in IE11:

SCRIPT1003: Expected ':' error on IE11

And it specifically refers to this line in the code of your plugin:

this.$emit('inputChange', { newVal, oldVal }, this.id);

I am using Babel but it doesn't seem to fix it..

Any ideas how to get around this?

Cheers

jebarjonet commented 4 years ago

The problem comes from here https://github.com/olefirenko/vue-google-autocomplete/blob/3f1ac32f33a9ec5e38b107537d5eb8f77bc3ae33/src/VueGoogleAutocomplete.vue#L70

Because IE11 does not interpret ES5 syntax correctly, instead of:

data() { ... }

it wants

data: function () { ... }

That's because this library is not compiled when distributed. This is related to https://github.com/olefirenko/vue-google-autocomplete/issues/92

mrdigitalau commented 4 years ago

Hey @jebarjonet, did you figure out a workaround on it by any chance? I am assuming we need to fork the project to fix it?

jebarjonet commented 4 years ago

@mrdigitalau yes, this library being only 1 component I copy/pasted it in my code directly and kept only the pieces I needed.