olefredrik / FoundationPress

FoundationPress is a WordPress starter theme based on Foundation 6 by Zurb
https://foundationpress.olefredrik.com
MIT License
2.7k stars 869 forks source link

Feature request: remove comments.php template #1291

Closed derweili closed 6 years ago

derweili commented 6 years ago

The FoundationPress theme comes with a custom comment form template (comments.php) that overwrites the wordpress default comment form with harcoded input fields. Since is does not include any Foundation specific adjustments/functions I'm wondering if the custom template is really necassary.

The custom template has no advantages, but instead some disadvantages:

For these reasons I would recommend to remove the comments.php from FoundationPress.

dantahoua commented 6 years ago

Are you sure there is nothing involved between comments and Foundation? Because there is the 'library/class-foundationpress-comments.php' file... But when I look at it, seems there is no reference to any Foundation class... So I second that also, let's keeps the comment to wordpress or to the user who want to customize them...

dantahoua commented 6 years ago

Just encounter a problem with comments.php... For the first time I use it! And there is a pluguin who is supposed to add a ReCaptcha on the comment form on the website. Without comments.php it works, but if I use the FoundationPress comments.php, it do not works... It seems we need to use the special comment filter and function to be sure everything works ok...

derweili commented 6 years ago

@dantahoua I think the best way ist to keep the comments.php but to replace the hardcoded comment form with the comment_form(); template tag

This template tag includes all necessary hooks to support third party plugins.

derweili commented 6 years ago

solved by #1296