Update Build Process and Dependencies

olefredrik / FoundationPress

FoundationPress is a WordPress starter theme based on Foundation 6 by Zurb

https://foundationpress.olefredrik.com

MIT License

2.7k stars 869 forks source link

Update Build Process and Dependencies #1346

Open derweili opened 5 years ago

derweili commented 5 years ago

The build process should be updated because of following reasons:

The official supported node version 6.11 from Oct. 2017 is outdated
There are 12 vulnerabilities (10 moderate, 2 high) within the dependencies
There are many issues related to the build process e.g. #1340 #1334 #1330 #1328 #1323 #1316 #1314 #1312
The phpcs and phpcbf tasks do not work anymore

So we need to:

update npm packages
update build process to work with the latest node version
check if there are other reported errors with the build process in the mentioned issues
fix or delete the phpcs and phpcbf tasks

kLOsk commented 5 years ago

I'm wondering what's the general opinion regarding sticking with NPM and Gulp, or if there is some interest in moving to Yarn and for example WebPack, or Parcel.js? I haven't worked with parcel yet, but I like the simplistic approach about it. It might be an easier approach for most users considering this is a WordPress Starter Theme.

JPOak commented 5 years ago

I have a branch called foundationpress-webpack, which is Webpack 4 and Foundationpress no gulp. Still a work in progress, but should work . Give it a go if you have interest as maybe parts of it can be of use. Be sure to read the readme as the build commands are different. Also, you need the latest version of node.js .

kLOsk commented 5 years ago

Thanks JPOak. reviewing the build process I actually noticed that a webpack plugin is already used for Javascript bundling and the dev server. @derweili I think you have a better picture on this. Do you think it makes sense trying to simplify the build process at this stage, given that Gulp4 now includes its own dev server, or that other solutions are available now too?

AndrewLee0 commented 5 years ago

How can I install foundation with this in mind?

kLOsk commented 5 years ago

@AndrewLee0 what do you mean?

derweili commented 5 years ago

@AndrewLee0 you can use FoundationPress now. It should be possible to update to a new build process later although you don't have to if you don't want to change.

Because we don't know which build process we will choose for the future we can't give you more info.

derweili commented 5 years ago

@JPOak that really looks good. I will try try you Webpack implementation in the next days. @kLOsk I'm not very happy with the current build process because it uses gulp and webpack side by side. Both gulp and webpack can take over both parts of the build process completely. So it is not necessary that gulp takes over one part and Webpack the other part. This makes everything unnecessarily complicated.

It would therefore be useful to choose one of the two, which would then take over everything.

Alternatively it is maybe possible to privide a "simple" build process in gulp and an advanced process in webpack. So the user can choose what process he wants. But that would mean double the effort.

Qubical commented 5 years ago

Late to this and just a thought but would Laravel-Mix be a good fit here?