Closed pixelbrad closed 5 years ago
How can this bug be reproduced?
Step one Call pagination function
Step two Inspect page source
Step three Observe that classless LI's are missing their closing LI tags.
What did you expect to happen?
I expected closing LI tags to be present for all LI's.
What happened instead?
Closing LI tags are missing on classless LI tags.
Expected markup:
<ul class="pagination text-center"> <li class="current" aria-current="page"><span class="show-for-sr">You're on page </span>1</li> <li><a href="http://localhost:3000/blog/page/2/" aria-label="Page 2">2</a></li> <li><a href="http://localhost:3000/blog/page/3/" aria-label="Page 3">3</a></li> <li><a href="http://localhost:3000/blog/page/4/" aria-label="Page 4">4</a></li> <li><a href="http://localhost:3000/blog/page/5/" aria-label="Page 5">5</a></li> <li><a href="http://localhost:3000/blog/page/6/" aria-label="Page 6">6</a></li> <li class="ellipsis" aria-hidden="true"></li> <li><a href="http://localhost:3000/blog/page/10/" aria-label="Page 10">10</a></li> <li class="next"><a href="http://localhost:3000/blog/page/2/" aria-label="Next page"><i class="fas fa-angle-right"><span class="show-for-sr">Next page</span></i></a></li> </ul>
Actual markup:
<ul class="pagination text-center"> <li class="current" aria-current="page"><span class="show-for-sr">You're on page </span>1</li> <li><a href="http://localhost:3000/blog/page/2/" aria-label="Page 2">2</a> <li><a href="http://localhost:3000/blog/page/3/" aria-label="Page 3">3</a> <li><a href="http://localhost:3000/blog/page/4/" aria-label="Page 4">4</a> <li><a href="http://localhost:3000/blog/page/5/" aria-label="Page 5">5</a> <li><a href="http://localhost:3000/blog/page/6/" aria-label="Page 6">6</a> <li class="ellipsis" aria-hidden="true"></li> <li><a href="http://localhost:3000/blog/page/10/" aria-label="Page 10">10</a> <li class="next"><a href="http://localhost:3000/blog/page/2/" aria-label="Next page"><i class="fas fa-angle-right"><span class="show-for-sr">Next page</span></i></a></li> </ul>
Please List the Following:
node_modules/foundation-sites/package.json
Include Test Case (if applicable): N/A
The PR that fixes this issue has been merged. Not sure why this issue wasn't automatically closed. Closing it now.
How can this bug be reproduced?
Step one Call pagination function
Step two Inspect page source
Step three Observe that classless LI's are missing their closing LI tags.
What did you expect to happen?
I expected closing LI tags to be present for all LI's.
What happened instead?
Closing LI tags are missing on classless LI tags.
Expected markup:
Actual markup:
Please List the Following:
node_modules/foundation-sites/package.json
) : N/AInclude Test Case (if applicable):
N/A