oleg-andreyev / MinkPhpWebDriver

Webdriver driver for Mink framework
MIT License
8 stars 9 forks source link

Reset driver connection even if stopping the driver fails #87

Closed andrewnicols closed 1 month ago

andrewnicols commented 1 month ago

This change ensures that if an error occurs whilst stopping the driver, that the current driver is still discarded and does not impact subsequent tests.

We have experienced issues when testing large datasets whereby the page takes a significant amount of time to load, blocking the driver. As a result the connection timeout is encountered, and the Behat Scenario fails.

We also restart the browser between every test to ensure that all caches are cleared. We do this in a Behat hook.

When we come to restart the connection and start the next test the WebDriver connection is still hung causing another exception to be thrown during the reset and no way to discard the session and start a new one.

Generally this happens very rarely, but when it does happen it currently causes the entire testrun to be aborted and a rerun runs the entire testsuite rather than just the test that originally caused the failure.

oleg-andreyev commented 1 month ago

Thanks https://github.com/oleg-andreyev/MinkPhpWebDriver/releases/tag/v1.3.2 🙏