oleg-shilo / Favorites.vscode

VSCode extension for managing Favorites
MIT License
23 stars 6 forks source link

Open new files from the list not working as expected #13

Closed koansoftware closed 2 years ago

koansoftware commented 4 years ago

Your extension is the closest extension to the feature I need. It's awesome, thank you !

The popup menu option "Open new files from the list" is not working as expected, because opens only the selected file. I'd suggest to have two different options:

Thank you

oleg-shilo commented 4 years ago

Makes sense. Agree.

Though there is something strange about it.

The context menu "Open new files from the list" does not actually exist. I cannot see it. At all.

On the other hand "Open all files in the list" exists and works perfectly.

image

"Open selected file" does not make much sense as the file is automatically opened when the item is selected.

Though....

The context menu is broken when TreeView is hosted in the its own activitybar. So will be visitig menus anyway.

koansoftware commented 4 years ago

@oleg-shilo you are right, it was a typo. "Open all files in the list" exists BTW it works only after you add the "workbench.editor.enablePreview" property, and set it's value to false.

oleg-shilo commented 4 years ago

txs, will have a look