search

oleg-shilo / Favorites.vscode

VSCode extension for managing Favorites
MIT License
23 stars 6 forks source link

Add icon #21

Closed lonix1 closed 3 years ago

lonix1 commented 3 years ago

By default the extension adds a section to the "Explorer" view.

I dragged it to the activity panel - so now it has its own full panel. But it uses the same icon as the explorer view (two pages on top of each other).

Please add an icon to make it stand out?

oleg-shilo commented 3 years ago

I am not sure I follow. I just dragged it to the activity bar and it seems to have the right icon: image

oleg-shilo commented 3 years ago

I think I know what happens. In your case the default setting is playing the trick with the IDE. I will need to have a look at it but for now you can fix it by enabling "Own Explorer" setting: image

lonix1 commented 3 years ago

Yes it works!! Thanks @oleg-shilo.

LOL small suggestion though... That star icon is not centered, it's right aligned. I know, I know, that's a silly small problem. :stuck_out_tongue:

Thanks for this excellent plugin!

oleg-shilo commented 3 years ago

Will have a look :)

Though it is so-o-o-o annoying. I haven't touch this extension for 6 month. I cannot compile it!!! 48 errors

The VSCode API is so volatile that it is 100% guaranteed that even the smallest task as recompiling the codebase (e.g. to update an icon) becomes a task for three evenings :(

And it happens every time I do not touch the extension for some time. It's almost like it's not a good place for stable products.

I love VSCode but this aspect of it is really damaging its image.

lonix1 commented 3 years ago

This is something I've heard on multiple repos. In many cases devs just recode from scratch a "version 2" than try fix v1.

Frustrating.

lonix1 commented 3 years ago

Thanks for fixing that. Works nicely.

Remember to "center align" the icon if that's at all possible :smile:

oleg-shilo commented 3 years ago

I had a look at alignment issue. VS Code does not support an alignment. It simply takes the icon file ad decides how to render it. And I see no alignment in the SVG definition of the icon file. So I am not sure what are the options I have to control/fix it.

lonix1 commented 3 years ago

VSCode is the best, until you hit some weird corner case - and it's always something small, like this!

Thanks for looking into it.

lonix1 commented 3 years ago

I looked into how another popular extension does it, and it's meant to be 24x24, whereas this extension uses a 16x16, and as you can see from the icon itself, it's "right aligned" as in it's physically on the right of the image.

I edited the svg in inkscape: 1) enlarged to 24x24 canvas, 2) enlarged vector to fit, 3) ensured it is centered, 4) minified it.

I don't know how to test it as I've never written an extension. It may / may not look good. I hope it works?

oleg-shilo commented 3 years ago

You are my friend a hopeless perfectionist. And I absolutely respect (and share) this quality :o)

The update v1.5.1 is available.

lonix1 commented 3 years ago

Guilty as charged! :stuck_out_tongue: